Re: [PATCH V2 6/6] coresight-stm: adding driver for CoreSight STM component

From: Alexander Shishkin
Date: Fri Feb 05 2016 - 08:06:37 EST


Chunyan Zhang <zhang.chunyan@xxxxxxxxxx> writes:

> +#ifndef CONFIG_64BIT
> +static inline void __raw_writeq(u64 val, volatile void __iomem *addr)
> +{
> + asm volatile("strd %1, %0"
> + : "+Qo" (*(volatile u64 __force *)addr)
> + : "r" (val));
> +}

Is it really ok to do this for all !64bit arms, inside a driver, just
like that? I'm not an expert, but I'm pretty sure there's more to it.

Regards,
--
Alex