Re: [PATCH V2] i2c: i801: Adding Intel Lewisburg support for iTCO

From: Jean Delvare
Date: Fri Feb 05 2016 - 04:49:05 EST


On Fri, 5 Feb 2016 00:27:46 +0100, Wolfram Sang wrote:
> On Thu, Feb 04, 2016 at 03:06:55PM -0800, Alexandra Yates wrote:
> > Starting from Intel Sunrisepoint (Skylake PCH) the iTCO watchdog
> > resources have been moved to reside under the i801 SMBus host
> > controller whereas previously they were under the LPC device.
> >
> > This patch adds Intel lewisburg SMBus support for iTCO device.
> >
> > Signed-off-by: Alexandra Yates <alexandra.yates@xxxxxxxxxxxxxxx>
>
> Please state what has changed in v2 of this patch?

Yes, Alexandra, please always include a changelog (between the ---
separator and the diffstat) when posting patch updates.

In this case there is no code change, the only change is the subject.

If I understand correctly, this is a fixup for commit
cdc5a3110e7c3ae793f367285789a6bc39c962dc ("i2c: i801: add Intel
Lewisburg device IDs") which should have included these changes. If so,
please mention it in the commit message. It may also make sense to tag
the patch for stable [v4.4].

Reviewed-by: Jean Delvare <jdelvare@xxxxxxx>

Thanks,
--
Jean Delvare
SUSE L3 Support