Re: [PATCH RESEND] kprobe: Use percpu counter to collect nhit statistics

From: Steven Rostedt
Date: Thu Feb 04 2016 - 08:20:06 EST


On Thu, 4 Feb 2016 10:24:12 +0000
åæéå / HIRAMATUïMASAMI <masami.hiramatsu.pt@xxxxxxxxxxx> wrote:

> From: Martin KaFai Lau [mailto:kafai@xxxxxx]
> >
> >When doing ebpf+kprobe on some hot TCP functions (e.g.
> >tcp_rcv_established), the kprobe_dispatcher shows up in 'perf report'.
> >
> >In kprobe_dispatcher(), there is a lot of cache bouncing
> >in 'tk->nhit++'. 'tk->nhit' and 'tk->tp.flags' also share
> >the same cacheline.
> >
>
> Ingo, could you consider to merge this?
>

Ingo, you can also add my

Acked-by: Steven Rostedt <rostedt@xxxxxxxxxxx>

-- Steve