Re: [PATCH v3] iio: adc: Add TI ADS1015 ADC driver support

From: Daniel Baluta
Date: Thu Feb 04 2016 - 07:51:34 EST


> Would it be more consistent to handle the mutex outside of the switch above similar
> to how it is handled in ads1015_write_raw?
>
> Also the ads1015_set_power_state(data, false) is called either way so why not just
> use one call?
>

I don't have a strong preference for that. I think across IIO drivers
we can find both coding practices.

Indeed consistency with ads1015_write_raw is a good argument. Will fix it.

I will leave the code here for one more day and then send an updated version.

thanks,
Daniel.