Re: [PATCH V3 5/5] rtc: max77686: move initialisation of rtc regmap, irq chip locally

From: Laxman Dewangan
Date: Thu Feb 04 2016 - 05:24:37 EST



On Thursday 04 February 2016 02:38 PM, Krzysztof Kozlowski wrote:
On 04.02.2016 15:58, Krzysztof Kozlowski wrote:
On 04.02.2016 11:03, Laxman Dewangan wrote:
3. Can you try locally to not use devm_regmap_init_i2c() and just use
the regmap_init_i2c() and proper removal of this from error path and
remove callback?
I'll try to find some time for that. Maybe tomorrow.
regmap_init_i2c does not help. However helps commenting out the:
regmap_del_irq_chip(info->rtc_irq, info->rtc_irq_data);
from remove() callback.



Thanks for debugging. I do not see anything on regmap_del_irq_chip() which can be suspected. Is this because of sharing interrupt between mfd and rtc driver?

What is your suggestion here? Should we avoid this inside RTC driver (creating this in mfd) and pass this information to the rtc driver using customized platform driver?