Re: [PATCH 2/2] net/smscx5xx: use the device tree for mac address

From: Arnd Bergmann
Date: Thu Feb 04 2016 - 03:24:49 EST


On Thursday 04 February 2016 08:36:04 Lubomir Rintel wrote:
>
> [lkundrak@xxxxx: updated to use of_get_property() as per suggestion from Arnd,
> reworded the message and comments a bit]
>
> Tested-by: Lubomir Rintel <lkundrak@xxxxx>
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
>

Looks good to me now. We could debate which MAC address should
be used when both EEPROM and DT exist. The current version prefers
the EEPROM address, and I think some other drivers do the opposite,
but I don't really know which is best.

Arnd