Re: [PATCH 3/11] cpufreq: governor: Use common global_dbs_data pointer

From: Viresh Kumar
Date: Thu Feb 04 2016 - 00:38:32 EST


On 04-02-16, 02:25, Rafael J. Wysocki wrote:
> You are talking about something like this now:
>
> if (condition)
> goto label;
>
> return 0;
>
> label:
> do stuff
>
> I'm sorry, but I fail to see how this is easier to read than
>
> if (!condition)
> return 0;
>
> do stuff

I have seen few people (Like Dan Carpenter), mostly coccinelle guys,
saying that we should write code like this:

if (error)
...

return success;

Though I should accept that I would have written code the way Rafael
has done this time, but those people get back everytime :)

--
viresh