Re: [PATCH v10 5/5] Watchdog: ARM SBSA Generic Watchdog half timeout panic support

[Guenter Roeck]

On 02/03/2016 03:00 PM, Fu Wei wrote:
> On 4 February 2016 at 02:45, Timur Tabi <timur@xxxxxxxxxxxxxx> wrote:
> > Fu Wei wrote:
> > > As you know I have made the pre-timeout support patch, If people like
> > > it, i am happy to go on upstream it separately.
> > >
> > > If we want to use pre-timeout here, user only can use get_pretimeout
> > > and disable panic by setting pretimeout to 0
> > > but user can not really set pretimeout, because "pre-timeout  ==
> > > timeout / 2 (always)".
> > > if user want to change pretimeout, he/she has to set_time instead.
> >
> >
> > Ok, I think patches 4 and 5 should be combined, and I think the Kconfig
> > entry should be removed and just use panic_enabled.

Agreed.
> NP, will update this patchset like that ,  thanks :-)

Also, if panic is enabled, the timeout needs to be adjusted accordingly
(to only panic after the entire timeout period has expired, not after
half of it). We can not panic the system after timeout / 2.

I am not too happy with the parameter name (panic_enabled). How about
"action", to match machzwd ?

Thanks,
Guenter