Re: [PATCH] init: print warning message if /dev/console failed to open

From: Peter Hurley
Date: Wed Feb 03 2016 - 14:29:40 EST


Hi Alexander,

On 02/03/2016 10:58 AM, Alexander Kuleshov wrote:
> Signed-off-by: Alexander Kuleshov <kuleshovmail@xxxxxxxxx>
> ---
> init/do_mounts.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/init/do_mounts.c b/init/do_mounts.c
> index dea5de9..ca5da05 100644
> --- a/init/do_mounts.c
> +++ b/init/do_mounts.c
> @@ -505,7 +505,9 @@ void __init change_floppy(char *fmt, ...)
> termios.c_lflag |= ICANON;
> sys_ioctl(fd, TCSETSF, (long)&termios);
> sys_close(fd);
> - }
> + } else
> + pr_err("Warning: unable to open /dev/console.\n");

I think you should include the -fd error code as well.

Is this failure new?


Regards,
Peter Hurley

> +
> }
> #endif
>
>