Re: [PATCH v3] regulator: qcom-saw2: Add support for SAW2 regulators

From: Georgi Djakov
Date: Wed Feb 03 2016 - 12:28:57 EST


On 02/01/2016 12:31 PM, Georgi Djakov wrote:
> The SAW2 (Subsystem Power Manager and Adaptive Voltage Scaling Wrapper 2)
> is part of the SPM subsystem. It is a hardware block in the Qualcomm
> chipsets that regulates the power to the CPU cores on platform such as
> apq8064, msm8974, apq8084 and others.
>
> Signed-off-by: Georgi Djakov <georgi.djakov@xxxxxxxxxx>
> ---
[..]

> +config REGULATOR_QCOM_SAW2
> + tristate "Qualcomm SAW2 regulator driver"
> + depends on ARCH_QCOM

This should be:
depends on (ARCH_QCOM || COMPILE_TEST) && MFD_SYSCON

I plan to re-send after a few more days and also change the name of the
driver from SAW2 to SAW, as we can add support for other generations
than just 2.

> + help
> + If you say yes to this option, support will be included for the
> + regulators providing power to the CPU cores on devices such as
> + APQ8064.
> +
> + Say M here if you want to include support for the CPU core voltage
> + regulators as a module. The module will be named
> + "qcom_saw2-regulator".
> +