Re: [RFC][PATCH 4/4] sched: Add debugfs/sched/deadline_bw file to show current bandwidths

From: Ingo Molnar
Date: Wed Feb 03 2016 - 05:12:23 EST



* Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:

> On Mon, Feb 01, 2016 at 05:38:09PM -0500, Steven Rostedt wrote:
>
> > Regardless of this final patch, what do you think of the first three? I
> > can send them as a separate series, just to get more of the SCHED_DEBUG
> > code into debug.c.
>
> The first two looked ok, the third I had a vague niggle it might be part
> of something bigger and tearing it up like this might make it harder.

Yeah, so the purpose of kernel/sched/debug.c is mostly meant as a filesystem
interface to display various internal scheduler details. It mostly deals with
/proc/sched_debug details: hence the name.

Note that 'sched domain debugging' does not fit into that cleanly, because it also
does sanity checking of the sched-domains data. So I'm not sure we want to do
patch #3 that moves sched-domain debugging to debug.c.

So debug.c is named in a bit too generic fashion, attracting such patches.

Thanks,

Ingo