Re: [PATCH 2/4] rtc: max77686: use rtc regmap to access RTC registers

From: Javier Martinez Canillas
Date: Tue Feb 02 2016 - 22:08:28 EST


Hello Laxman

On 02/02/2016 10:16 AM, Laxman Dewangan wrote:
rtc_regmap should be used to access all RTC regsiters instead

s/regsiters/registers

of parent regmap regardless of what chip or property have it.

This makes the register access uniform and extendible for other
chips.

Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>
CC: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
CC: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
---
drivers/rtc/rtc-max77686.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)


Thanks for the patch, I indeed should had used rtc_regmap for consistency.

Reviewed-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>

Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America