Re: [PATCH 0/7] Use devm_request_region

From: Alexandre Courbot
Date: Tue Feb 02 2016 - 19:26:38 EST


On Tue, Feb 2, 2016 at 8:54 AM, William Breathitt Gray
<vilhelm.gray@xxxxxxxxx> wrote:
> By the time request_region is called in several GPIO drivers, a
> corresponding device structure has already been allocated. The
> devm_request_region function should be used to help simplify the cleanup
> code and reduce the possible points of failure.
>
> William Breathitt Gray (7):
> gpio: 104-dio-48e: Use devm_request_region
> gpio: 104-idi-48: Use devm_request_region
> gpio: 104-idio-16: Use devm_request_region
> gpio: amd8111: Use devm_request_region
> gpio: ich: Use devm_request_region
> gpio: sch311x: Use devm_request_region
> gpio: ws16c48: Use devm_request_region
>
> drivers/gpio/gpio-104-dio-48e.c | 22 +++++++-----------
> drivers/gpio/gpio-104-idi-48.c | 22 +++++++-----------
> drivers/gpio/gpio-104-idio-16.c | 22 +++++++-----------
> drivers/gpio/gpio-amd8111.c | 7 +++---
> drivers/gpio/gpio-ich.c | 51 ++++++++---------------------------------
> drivers/gpio/gpio-sch311x.c | 7 +++---
> drivers/gpio/gpio-ws16c48.c | 22 +++++++-----------
> 7 files changed, 47 insertions(+), 106 deletions(-)

Did a quick review and this looks all good, modulo the compile warning
on patch 6.

Reviewed-by: Alexandre Courbot <acourbot@xxxxxxxxxx>