Re: [RFC][PATCH] mips: Fix arch_spin_unlock()

From: Linus Torvalds
Date: Tue Feb 02 2016 - 14:56:02 EST


On Tue, Feb 2, 2016 at 11:30 AM, Will Deacon <will.deacon@xxxxxxx> wrote:
>
> FWIW, and this is by no means conclusive, I hacked that up quickly and
> ran hackbench a few times on the nearest idle arm64 system. The results
> were consistently ~4% slower using acquire for rcu_dereference.

Ok, that's *much* more noticeable than I would have expected. I take
it that load-acquire is really really slow on current arm64
implementations.

That, btw, is one reason why I despise weak memory ordering. In most
cases I've ever seen, the hardware designers have said "barriers don't
much matter" and just made them crazy slow. My old alpha was the worst
of the worst.

It's shades of my least favorite x86 microarchitecture ever: netburst.
Make common cases fast, but make exceptional cases _so_ slow that it's
actually a noticeable pain.

Just out of interest, is store-release slow too? Because that should
be easy to make fast.

Linus