Re: [PATCH 08/11] clk: sunxi: improve error reporting for the mux clock

From: Maxime Ripard
Date: Tue Feb 02 2016 - 13:03:12 EST


On Mon, Feb 01, 2016 at 05:39:27PM +0000, Andre Przywara wrote:
> clk_register_mux returns a pointer wrapped error value in case of
> failure, so a simple NULL check is not sufficient to catch errors.
> Fix that and elaborate on the failure reason on the way. The whole
> function does not return any error value, so silently failing may
> leave users scratching their heads because the kernel does not
> provide any clues on what's wrong.
>
> Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>

Applied, thanks.

Any chance you do that for the other functions? :)

Thanks!
Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Attachment: signature.asc
Description: Digital signature