Re: [PATCH v2 0/5] alienware-wmi new platform and feature support

From: Darren Hart
Date: Tue Feb 02 2016 - 12:39:37 EST


On Mon, Feb 01, 2016 at 08:28:46PM -0600, Mario Limonciello wrote:
> I've got some extensions for the alienware-wmi driver that have
> been introduced for a few new platforms and can be controlled via the WMI
> interface.
>
> Changes from V1:
> - Make sure whitespace changes are in their own patch
> - Add commit descriptions to all patches
> - Allow one line to go over 80 characters in deep sleep control patch
> Other patches may have some areas that avoid going over 80 characters
> still, but this matches the style of the existing driver. If you would
> like these to go over 80 characters as well, please comment which areas
> this is OK.

This made it much easier to review. Thank you Mario. A few changes requested,
and a couple questions for you regarding intent/best-practice.

Thanks!

--
Darren Hart
Intel Open Source Technology Center