Re: [PATCH] affs: add kunmap in error path

From: Al Viro
Date: Mon Feb 01 2016 - 21:24:45 EST


On Mon, Feb 01, 2016 at 08:55:17PM -0500, Insu Yun wrote:
> When error occurs, it needs to unmap page.

Point, but... I'm not sure there's any point in keeping it mapped all
along. After all, what we are doing is a bunch of memcpy() into the
parts of page, so kmap_atomic()/kunmap_atomic() just around memcpy
would do just fine.