Re: [PATCH v2] ata: add AMD Seattle platform driver

[Brijesh Singh]

Hi,

> 
> This is where we really need the ACPI maintainers to explain the
> general policy for dealing with firmware updates.
> 
> I would assume that adding the feature in a later firmware version
> is a compatible change, and the feature is non-essential (the
> device will work fine with the generic SATA driver, except
> the LEDs don't blink), so it's not a big deal, it's just what
> you get for having the firmware shipped before the driver is
> reviewed (don't do that).
> 

Agreed, the driver should have been reviewed earlier. And now changes in firmware will also require
them changing other OSes drivers.

Just speaking my mind, maybe server folks will be fine without activity LED but I think "locate" and "fault" LEDs is needed.

-Brijesh

> 	Arnd
>