Re: [PATCH] mm: Use linear_page_index() in do_fault()

From: Matthew Wilcox
Date: Mon Feb 01 2016 - 15:44:00 EST


On Mon, Feb 01, 2016 at 03:06:38PM +0200, Kirill A. Shutemov wrote:
> On Sun, Jan 31, 2016 at 11:13:21PM +1100, Matthew Wilcox wrote:
> > do_fault assumes that PAGE_SIZE is the same as PAGE_CACHE_SIZE.
> > Use linear_page_index() to calculate pgoff in the correct units.
> >
> > Signed-off-by: Matthew Wilcox <matthew.r.wilcox@xxxxxxxxx>
>
> Acked-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>
>
> 'linear' part of helper name is not relevant any more since we've dropped
> non-linear mappings. Probably, we should rename helpers.

Ah, that's what it was named for. Yes, probably.