Re: [PATCH 4/4] sched,time: only call account_{user,sys,guest,idle}_time once a jiffy

From: Rik van Riel
Date: Mon Feb 01 2016 - 15:08:45 EST


On 02/01/2016 03:00 PM, Eric Dumazet wrote:
> On Mon, 2016-02-01 at 14:21 -0500, riel@xxxxxxxxxx wrote:
>> From: Rik van Riel <riel@xxxxxxxxxx>
>>
>
>> #ifdef CONFIG_VIRT_CPU_ACCOUNTING_GEN
>> +static bool vtime_jiffies_changed(struct task_struct *tsk, unsigned long now)
>> +{
>> + if (tsk->vtime_jiffies == jiffies)
>> + return false;
>> +
>> + tsk->vtime_jiffies = jiffies;
>> + return true;
>> +}
>
> I am guessing you intended to use 'now' instead of jiffies ?

Yes indeed. Good catch.

I have fixed this up in my local tree, and will wait for
more people's comments before sending out a v5 (tomorrow?).

--
All rights reversed