Re: [PATCH v2 3/3] input: touchscreen: ad7879: add device tree support

From: Rob Herring
Date: Mon Feb 01 2016 - 10:13:16 EST


On Fri, Jan 29, 2016 at 03:48:15PM -0800, Stefan Agner wrote:
> Add device tree support for the I2C and SPI variant of AD7879(-1).
> This allows to specify the touchscreen controller as a I2C client
> node or SPI slave device. Most of the options available in platform
> data are also available as device tree properties, the only exception
> being GPIO capabilities, which can not be activated through device
> tree currently.
>
> Signed-off-by: Stefan Agner <stefan@xxxxxxxx>
> ---
> Changes since v1:
> - Move device tree parsing to main driver file ad7879.c
> - Use common touchscreen_parse_properties for common properties
> - Use device_property_* API
> - Use struct ad7879 directly to store parsed values
> - Support SPI variant through device tree too (untested)
> - Add vendor prefix to vendor specific dt properties
>
> .../bindings/input/touchscreen/ad7879.txt | 53 ++++++++

Acked-by: Rob Herring <robh@xxxxxxxxxx>

> drivers/input/touchscreen/ad7879-i2c.c | 10 ++
> drivers/input/touchscreen/ad7879-spi.c | 10 ++
> drivers/input/touchscreen/ad7879.c | 141 +++++++++++++--------
> 4 files changed, 160 insertions(+), 54 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/input/touchscreen/ad7879.txt