Re: [PATCH 1/2] livepatch: Implement separate coming and going module notifiers

From: Josh Poimboeuf
Date: Mon Feb 01 2016 - 09:48:17 EST


On Mon, Feb 01, 2016 at 01:27:57PM +0100, Jiri Kosina wrote:
> On Fri, 29 Jan 2016, Josh Poimboeuf wrote:
>
> > Right, as you say it's basically a nop 99.99% of the time. But we still
> > need to do the "are any patches loaded" check, so we still need the call
> > into a livepatch function to do that.
>
> We might create a static key for that (some might call it
> over-optimization though, given it's happening on kind of a slow path
> anyway).

I really don't think that's needed. Nobody will notice an extra
function call in the module load path. (And BTW it'll be slightly
faster than today since it doesn't go through the notifier first.)

--
Josh