Re: [PATCH 3/5] btrfs: Use radix_tree_iter_retry()

From: David Sterba
Date: Mon Feb 01 2016 - 09:34:54 EST


On Wed, Jan 27, 2016 at 04:17:50PM -0500, Matthew Wilcox wrote:
> From: Matthew Wilcox <willy@xxxxxxxxxxxxxxx>
>
> Even though this is a 'can't happen' situation, use the new
> radix_tree_iter_retry() pattern to eliminate a goto.

Andrew's tree contains a fixup for a build failure

> @@ -147,7 +146,7 @@ restart:
> /* Shouldn't happen but that kind of thinking creates CVE's */
> if (radix_tree_exception(eb)) {
> if (radix_tree_deref_retry(eb))
> - goto restart;
> + slot = radix_tree_iter_retry(iter);

slot = radix_tree_iter_retry(&iter);

http://ozlabs.org/~akpm/mmots/broken-out/btrfs-use-radix_tree_iter_retry-fix.patch