Re: [PATCH V5 3/5] pinctrl: max77620: add pincontrol driver for MAX77620/MAX20024

[Rob Herring]

On Wed, Jan 27, 2016 at 07:40:06PM +0530, Laxman Dewangan wrote:
> MAXIM Semiconductor's PMIC, MAX77620/MAX20024 has 8 GPIO pins
> which also act as the special function in alternate mode. Also
> there is configuration like push-pull, open drain, FPS timing
> etc for these pins.
> 
> Add pincontrol driver to configure these parameters through
> pincontrol APIs.
> 
> Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>
> Signed-off-by: Chaitanya Bandi <bandik@xxxxxxxxxx>
> ---
> Changes from V1:
> - Cleanup code based on comment received on mfd/rtc.
> - Avoid duplication on error message.
>  
> Changes form V2:
> - Run coccicheck and checkpatch in strict mode for the alignment.
> - update based on api changes from core.
> 
> Changes from V3: 
> - Change all sys initcall to module driver.
> - change the max77620_read argument to unisgned int from u8.
> 
> Changes from V4: 
> - Added DT binding document as devicetree/bindings/pinctrl/pinctrl-max77620.txt
> - Detail out properties.
> 
>  .../bindings/pinctrl/pinctrl-max77620.txt          |  87 +++

Acked-by: Rob Herring <robh@xxxxxxxxxx>

>  drivers/pinctrl/Kconfig                            |  10 +
>  drivers/pinctrl/Makefile                           |   1 +
>  drivers/pinctrl/pinctrl-max77620.c                 | 693 +++++++++++++++++++++
>  4 files changed, 791 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pinctrl/pinctrl-max77620.txt
>  create mode 100644 drivers/pinctrl/pinctrl-max77620.c