Re: [tip:x86/asm] x86/syscalls: Remove __SYSCALL_COMMON and __SYSCALL_X32

From: Ingo Molnar
Date: Sat Jan 30 2016 - 04:31:39 EST



* Andy Lutomirski <luto@xxxxxxxxxxxxxx> wrote:

> >>>+ if [ "$abi" == "COMMON" -o "$abi" == "64" ]; then
> >>>+ # COMMON is the same as 64, except that we don't expect X32
> >>>+ # programs to use it. Our expectation has nothing to do with
> >>>+ # any generated code, so treat them the same.
> >>>+ emit 64 "$nr" "$entry" "$compat"
> >>>+ elif [ "$abi" == "X32" ]; then
> >>>+ # X32 is equivalent to 64 on an X32-compatible kernel.
> >>>+ echo "#ifdef CONFIG_X86_X32_ABI"
> >>>+ emit 64 "$nr" "$entry" "$compat"
> >>>+ echo "#endif"
> >>>+ elif [ "$abi" == "I386" ]; then
> >>>+ emit "$abi" "$nr" "$entry" "$compat"
> >>>+ else
> >>>+ echo "Unknown abi $abi" >&2
> >>>+ exit 1
> >>>+ fi

> No combinatorial explosion, please. We could use __SYSCALL(nr, sym,
> abi, qual), though.

Mind fixing it, so that we get back the arch-neutral property?

Thanks,

Ingo