Re: [PATCH] fbdev: mmp: print IRQ resource using %pR format string

From: Tomi Valkeinen
Date: Fri Jan 29 2016 - 06:44:15 EST




On 25/01/16 17:03, Arnd Bergmann wrote:
> resource_size_t cannot be printed using the %x format string
> when we it is defined as u64:
>
> drivers/video/fbdev/mmp/hw/mmp_ctrl.c: In function 'mmphw_probe':
> drivers/video/fbdev/mmp/hw/mmp_ctrl.c:506:22: error: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'resource_size_t {aka long long unsigned int}' [-Werror=format=]
> dev_err(ctrl->dev, "%s: res %x - %x map failed\n", __func__,
> ^
> drivers/video/fbdev/mmp/hw/mmp_ctrl.c:506:22: error: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'resource_size_t {aka long long unsigned int}' [-Werror=format=]
>
> This changes the format string to %pR, which is interpreted
> by the printk implementation to pretty-print a resource
> structure.

Thanks, queued for 4.5 fixes.

Tomi

Attachment: signature.asc
Description: OpenPGP digital signature