Re: [PATCH] Doc: Micrel-ksz90x1.txt: Update the Micrel phy documentation for ksz9031

From: Rob Herring
Date: Thu Jan 28 2016 - 22:33:17 EST


On Thu, Jan 28, 2016 at 10:49:27AM -0600, dinguyen@xxxxxxxxxxxxxxxxxxxxx wrote:
> From: Dinh Nguyen <dinguyen@xxxxxxxxxxxxxxxxxxxxx>
>
> Update the Micrel phy documentation for the KSZ9031 PHY to represent how
> the actual values are calculated from the code.
>
> Signed-off-by: Dinh Nguyen <dinguyen@xxxxxxxxxxxxxxxxxxxxx>
> ---
> .../devicetree/bindings/net/micrel-ksz90x1.txt | 73 ++++++++++++++++++++++
> 1 file changed, 73 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/micrel-ksz90x1.txt b/Documentation/devicetree/bindings/net/micrel-ksz90x1.txt
> index f9c32ad..9535b2b 100644
> --- a/Documentation/devicetree/bindings/net/micrel-ksz90x1.txt
> +++ b/Documentation/devicetree/bindings/net/micrel-ksz90x1.txt
> @@ -36,6 +36,71 @@ KSZ9031:
> value is 0, and the maximum is property-dependent. The increment
> step is 60ps.
>
> + The KSZ9031 hardware supports a range of skew values from negative to
> + positive, where the specific range is property dependent. All values
> + specified in the devicetree are offset by the minimum value so they
> + can be represented as positive integers in the devicetree since it's
> + difficult to represent a negative number in the devictree.

I don't think that is true anymore. dtc should allow negative numbers
AIUI. That would be much better here.

Rob