Re: [PATCH V2 4/4] serial: 8250_pci: Remove Fintek F81504/508/512 UART driver

From: Andy Shevchenko
Date: Thu Jan 28 2016 - 07:05:08 EST


On Thu, 2016-01-28 at 17:20 +0800, Peter Hung wrote:
> Remove Fintek F81504/508/512 PCIE-to-UART device driver from
> 8250_pci.c
>
> Paul recommed us do less code deletion to avoid confusing problem
> when
> bisect.
> https://lkml.org/lkml/2016/1/18/646
>
>


> - /* Fintek PCI serial cards */
> - { PCI_DEVICE(0x1c29, 0x1104), .driver_data = pbn_fintek_4 },
> - { PCI_DEVICE(0x1c29, 0x1108), .driver_data = pbn_fintek_8 },
> - { PCI_DEVICE(0x1c29, 0x1112), .driver_data = pbn_fintek_12
> },

Shouldn't you blacklist them in 8250_pci?

--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy