Re: [PATCH] Remove ambiguous logging for "Unsupported brightness interface"

From: Joe Perches
Date: Wed Jan 27 2016 - 19:43:51 EST


On Thu, 2016-01-28 at 00:36 +0000, Eric Curtin wrote:
> On 27 January 2016 at 23:26, Joe Perches <joe@xxxxxxxxxxx> wrote:
> > On Wed, 2016-01-27 at 22:14 +0000, Eric Curtin wrote:
> > > Message gets logged on machines that are well supported.
[]
> > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
[]
> > +       pr_info("detected %u brightness levels\n", bright_maxlvl + 1);
> >  }
> >
> >  static int __init brightness_init(struct ibm_init_struct *iibm)
>
> Maybe, but the other logging issues kinda mean something. There are
> many, many reports of people thinking their brightness interface is
> broken because of this logging message, when in reality the i915 driver
> supports their devices just fine as previously stated.

That's why I suggest changing it to show the number
of brightness levels detected on any device.