Re: [PATCH] regmap: mmio: Convert to regmap_bus and fix accessor usage

From: Arnd Bergmann
Date: Wed Jan 27 2016 - 10:51:34 EST


On Wednesday 27 January 2016 15:34:09 Mark Brown wrote:
> ---
> drivers/base/regmap/regmap-mmio.c | 261 ++++++++++++++++++++------------------
> 1 file changed, 140 insertions(+), 121 deletions(-)

Overall looks good to me, but one bug:

> +
> +#ifdef __64BIT
> +static void regmap_mmio_write64le(struct regmap_mmio_context *ctx,
> + unsigned int reg,
> + unsigned int val)
> +{
> + writeq(val, ctx->regs + reg);
> +}
> +#endif

s/__64BIT/CONFIG_64BIT/

here and in one other line.

Arnd