Re: [PATCH 2/2] iio: si7005: add support for Hoperf th02

From: Daniel Baluta
Date: Wed Jan 27 2016 - 04:13:35 EST


On Wed, Jan 27, 2016 at 12:56 AM, Matt Ranostay <mranostay@xxxxxxxxx> wrote:
> On Tue, Jan 26, 2016 at 12:21 PM, Cristina Moraru
> <cristina.moraru09@xxxxxxxxx> wrote:
>> This patch adds support for Hoperf th02 humidity and
>> temperature sensor as it uses same register definitions
>> as si7005
>>
>> th02 Datasheet: http://www.anglia-live.com/netalogue/pdfs/hrf/datasheets/TH02_V1.1.pdf
>>
>> Signed-off-by: Cristina Moraru <cristina.moraru09@xxxxxxxxx>
>> ---
>> drivers/iio/humidity/Kconfig | 3 ++-
>> drivers/iio/humidity/si7005.c | 1 +
>> 2 files changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/humidity/Kconfig b/drivers/iio/humidity/Kconfig
>> index c1f3a21..866dda1 100644
>> --- a/drivers/iio/humidity/Kconfig
>> +++ b/drivers/iio/humidity/Kconfig
>> @@ -43,7 +43,8 @@ config SI7005
>> humidity and temperature sensor.
>>
>> To compile this driver as a module, choose M here: the module
>> - will be called si7005.
>> + will be called si7005. This driver also
>> + supports Hoperf TH02 Humidity and Temperature Sensor.
>
> This probably shouldn't be changing the Kconfig description. Since if
> every driver added a line for each device/variant it supported
> everything would get quite wordy.

Wordy is good :). We usually add all the supported chips in the Kconfig.
See for example entries for BMC150_ACCEL or IIO_ST_ACCEL_3AXIS.

thanks,
Daniel.