Re: [PATCHSET 00/12] perf tools: Apply percent-limit to callchains

[Jiri Olsa]

On Wed, Jan 27, 2016 at 12:54:17AM +0900, Namhyung Kim wrote:

SNIP

> > > > > >      0.04%     0.04%  perf     [kernel.vmlinux]  [k] x86_pmu_enable              
> > > > > >      0.04%     0.04%  perf     [kernel.vmlinux]  [k] native_apic_mem_write       
> > > > > > 
> > > > > 
> > > > > What's the problem?  Now by default callchains under 0.5% (absolute)
> > > > > will not be shown.  I think this is intended output, and we need to
> > > > > consider changing the default percent limit.
> > > > 
> > > > hm, just the TUI shows +- for entries with no callchain
> > > 
> > > Humm, this is an old bug, never got around to try to fix it, or is this
> > > something you were not experiencing before this patchkit from Namhyung?
> > > 
> > 
> > well, there were callchains present before this patchset ;-)
> 
> That is because we apply percent limit to callchains now, and the
> default is 0.5%.  Before this patchset percent limit seems not applied
> so you saw the callchains under the limit.

I'm just saying that in TUI I see entries without callcains (which are filtered out)
but those entries are still marked with +- ... I dont know if that's some old issue

thanks,
jirka


---
+    0.08%     0.00%  perf     [kernel.vmlinux]  [k] perf_pmu_enable.part.87                                                              â
+    0.08%     0.00%  perf     [kernel.vmlinux]  [k] perf_event_context_sched_in                                                          â
+    0.08%     0.00%  perf     [kernel.vmlinux]  [k] perf_event_exec                                                                      â
+    0.08%     0.00%  perf     [kernel.vmlinux]  [k] setup_new_exec                                                                       â
+    0.08%     0.00%  perf     [kernel.vmlinux]  [k] load_elf_binary                                                                      â
+    0.08%     0.00%  perf     [kernel.vmlinux]  [k] search_binary_handler                                                                â
+    0.08%     0.00%  perf     [kernel.vmlinux]  [k] do_execveat_common.isra.33                                                           â
+    0.08%     0.00%  perf     [kernel.vmlinux]  [k] sys_execve                                                                           â
-    0.08%     0.00%  perf     [kernel.vmlinux]  [k] return_from_execve                                                                   â
-    0.08%     0.00%  perf     [unknown]         [k] 0x00007f2175b35e07                                                                   â
-    0.04%     0.00%  perf     [kernel.vmlinux]  [k] perf_event_nmi_handler                                                               â
-    0.04%     0.00%  perf     [kernel.vmlinux]  [k] nmi_handle                                                                           â
-    0.04%     0.00%  perf     [kernel.vmlinux]  [k] default_do_nmi                                                                       â
-    0.04%     0.00%  perf     [kernel.vmlinux]  [k] do_nmi                                                                               â
-    0.04%     0.00%  perf     [kernel.vmlinux]  [k] end_repeat_nmi                                                                       â
-    0.04%     0.04%  perf     [kernel.vmlinux]  [k] x86_pmu_enable                                                                       â
-    0.04%     0.04%  perf     [kernel.vmlinux]  [k] native_apic_mem_write                                                                â