Re: [PATCH V3 2/2] regulator: mt6323: Add support for MT6323 regulator

From: John Crispin
Date: Tue Jan 26 2016 - 06:00:18 EST




On 26/01/2016 11:41, Paul Bolle wrote:
> John,
>
> On ma, 2016-01-25 at 12:56 +0100, John Crispin wrote:
>> --- /dev/null
>> +++ b/drivers/regulator/mt6323-regulator.c
>
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License version 2 as
>> + * published by the Free Software Foundation.
>> + *
>> + * This program is distributed in the hope that it will be useful,
>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
>> + * GNU General Public License for more details.
>
> This states this file is licensed GPL v2 only.
>
>> +MODULE_LICENSE("GPL");
>
> And, according to include/linux/module.h, this means "GNU Public License
> v2 or later".
>
> So I think there's a (subtle) mismatch between the license ident used
> for this driver and the comment above.
>
> Thanks,
>
>
> Paul Bolle
>

Hi Paul,

thanks, good catch. luckily i had not sent the next version of the
series yet ;)

John

John