Re: [PATCH 1/3] printk: make preferred_console local static bool

From: Joe Perches
Date: Mon Jan 25 2016 - 08:23:34 EST


On Mon, 2016-01-25 at 18:51 +0600, Aleksey Makarov wrote:
>
> On 25.01.2016 18:45, Joe Perches wrote:
> > On Mon, 2016-01-25 at 17:45 +0600, Aleksey Makarov wrote:
> > > The variable preferred_console is used only inside register_console()
> > > and it's semantics is boolean.  Make it clear.
> >
> > This loses the index of the preferred console.
> > I'm not sure this is better.
>
> That index is not used anywhere.  I believe the patch makes things clear.

Well, with this change the name and its use
is a bit misleading.  Maybe changing it to
something like use_selected_console is better.