Re: [PATCH 1/2] drm/rockchip: Don't build rockchip_drm_vop as modules

From: Sjoerd Simons
Date: Mon Jan 25 2016 - 05:54:17 EST


On Wed, 2016-01-13 at 16:22 +0800, Mark Yao wrote:
> rockchip_drm_vop's module init had moved to rockchip_vop_reg.c
> so no need to build rockchip_drm_vop.ko

Looks like this didn't make it for the Linux 4.5 merge window, which
unfortunately means in 4.5-rc1 DRM on rockchip is broken :/

> Signed-off-by: Mark Yao <mark.yao@xxxxxxxxxxxxxx>
> ---
> Âdrivers/gpu/drm/rockchip/Makefile |ÂÂÂÂ5 ++---
> Â1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/rockchip/Makefile
> b/drivers/gpu/drm/rockchip/Makefile
> index a9d380f..9e6e992 100644
> --- a/drivers/gpu/drm/rockchip/Makefile
> +++ b/drivers/gpu/drm/rockchip/Makefile
> @@ -3,9 +3,8 @@
> Â# Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher.
> Â
> Ârockchipdrm-y := rockchip_drm_drv.o rockchip_drm_fb.o
> rockchip_drm_fbdev.o \
> - rockchip_drm_gem.o
> + rockchip_drm_gem.o rockchip_drm_vop.o
> Â
> Âobj-$(CONFIG_ROCKCHIP_DW_HDMI) += dw_hdmi-rockchip.o
> Â
> -obj-$(CONFIG_DRM_ROCKCHIP) += rockchipdrm.o rockchip_drm_vop.o \
> - rockchip_vop_reg.o
> +obj-$(CONFIG_DRM_ROCKCHIP) += rockchipdrm.o rockchip_vop_reg.o

--
Sjoerd Simons
Collabora Ltd.