Re: [PATCH] ideapad-laptop: Add Lenovo Yoga 700 to no_hw_rfkill dmi list

From: Darren Hart
Date: Sun Jan 24 2016 - 13:12:18 EST


On Sat, Jan 23, 2016 at 07:57:23AM -0500, Josh Boyer wrote:
> On Sat, Jan 23, 2016 at 2:27 AM, Darren Hart <dvhart@xxxxxxxxxxxxx> wrote:
> > On Mon, Jan 18, 2016 at 02:32:53PM -0500, Josh Boyer wrote:
> >> Like the Yoga 900 models the Lenovo Yoga 700 does not have a
> >> hw rfkill switch, and trying to read the hw rfkill switch through the
> >> ideapad module causes it to always reported blocking breaking wifi.
> >>
> >> This commit adds the Lenovo Yoga 700 to the no_hw_rfkill dmi list, fixing
> >> the wifi breakage.
> >>
> >> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1295272
> >> Tested-by: <dinyar.rabady+spam@xxxxxxxxx>
> >> Cc: stable@xxxxxxxxxxxxxxx
> >> Signed-off-by: Josh Boyer <jwboyer@xxxxxxxxxxxxxxxxx>
> >> ---
> >>
> >> This applies to the for-next branch of the platform-x86-drivers tree
> >>
> >>
> >> drivers/platform/x86/ideapad-laptop.c | 7 +++++++
> >> 1 file changed, 7 insertions(+)
> >>
> >> diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
> >> index d28db0e793df..51178626305d 100644
> >> --- a/drivers/platform/x86/ideapad-laptop.c
> >> +++ b/drivers/platform/x86/ideapad-laptop.c
> >> @@ -900,6 +900,13 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
> >> },
> >> },
> >> {
> >> + .ident = "Lenogo Yoga 700",
> >
> > Josh,
> >
> > Is this a typo? "Lenogo"? Please tell me it's a typo.... :-)
>
> Ugh, yes. A typo. One that apparently doesn't matter in
> functionality because the tester used this exact patch and things
> work, but embarrassing either way.
>
> Do you need me to send a v2, or is that something you can fixup?

Normally I could have just fixed it up. I had some emergency travel on Friday
until now, so couldn't get back to it. Thank you for resending.

--
Darren Hart
Intel Open Source Technology Center