Re: [PATCH 3/9] perf build: Test correct path of perf in build-test

[Wangnan (F)]

On 2016/1/14 17:57, Jiri Olsa wrote:
> On Wed, Jan 13, 2016 at 12:17:16PM +0000, Wang Nan wrote:
>
> SNIP
>
> > +test_make_python_perf_so := test -f $(PERF_OUT)/python/perf.so
> >   
> > -test_make_perf_o           := test -f $(PERF)/perf.o
> > -test_make_util_map_o       := test -f $(PERF)/util/map.o
> > -test_make_util_pmu_bison_o := test -f $(PERF)/util/pmu-bison.o
> > +test_make_perf_o           := test -f $(PERF_OUT)/perf.o
> > +test_make_util_map_o       := test -f $(PERF_OUT)/util/map.o
> > +test_make_util_pmu_bison_o := test -f $(PERF_OUT)/util/pmu-bison.o
> >   
> >   define test_dest_files
> >     for file in $(1); do				\
> > @@ -244,7 +246,7 @@ test_make_perf_o_O            := test -f $$TMP_O/perf.o
> >   test_make_util_map_o_O        := test -f $$TMP_O/util/map.o
> >   test_make_util_pmu_bison_o_O := test -f $$TMP_O/util/pmu-bison.o
> >   
> > -test_default = test -x $(PERF)/perf
> > +test_default = test -x $(PERF_OUT)/perf
> >   test = $(if $(test_$1),$(test_$1),$(test_default))
> >   
> >   test_default_O = test -x $$TMP_O/perf
> > @@ -264,7 +266,7 @@ endif
> >   
> >   MAKEFLAGS := --no-print-directory
> >   
> > -clean := @(cd $(PERF); make -s -f $(MK) clean >/dev/null)
> > +clean := @(cd $(PERF); make -s -f $(MK) O=$(PERF_OUT) clean >/dev/null; make -s -f $(MK) clean >/dev/null)
> what's the second make clean for?

I want to ensure the source directory is also clean.

Looks like I forget 'O' would be passed to the second make also...

> thanks,
> jirka