Re: [PATCH V2 6/6] regulator: max77620: add regulator driver for max77620/max20024

[Laxman Dewangan]

On Wednesday 13 January 2016 06:01 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Wed, Jan 13, 2016 at 05:35:33PM +0530, Laxman Dewangan wrote:
> > On Wednesday 13 January 2016 05:27 PM, Mark Brown wrote:
> > This is require to
> > - configure FPS_SRC based on platform data for each rail,
> >      - If FPS_SRC enabled then enable it always.
> >      - If FPS_SRC is disabled (NONE) then based on init data constraint,
> >        set it to desired state.
> What is FPS_SRC and why is it set from init_data?  A driver should never
> be looking at init_data.
FPS: Flexible Power Sequence.
Max77620 has three FPS source configuration FPS0,1 2 and can be 
configured with different digital input signals EN0, EN1 and EN2.
Then rails and few GPIOs can configured with these FPS SRC with 
different slots so that it can be controlled externally.

When FPS_SRC is set to NONE (this is needed from platform data) then 
based on constraint like boot enable/always enable, it need to be on 
desired state. Otherwise we may endup with disabling the rail when 
setting to NONE and create issue.

I need to set the FPS src properly for each rails before callback happen 
from regulator init so that enable/disable/is_enable can handle it properly.


> > - Power mode and slew rate init based on default configuration from the
> > register if platform does not want to set it.
> Same here, why is init_data needed here?
Here, init data is not needed. I was thinking to configure slew rate in 
preinit but can be done later also through regulator->ops.
But I will need the driver specific DT data (customized flag) to 
configure the PMIC like slots.