Re: [PATCH 1/3] ifb: make device count build-time configurable

[Lubomir Rintel]

On Tue, 2016-01-12 at 16:19 +0100, Daniel Borkmann wrote:
> On 01/12/2016 12:56 PM, Lubomir Rintel wrote:
> > The devices can be created at run-time for quite some time already
> > and the
> > load-time device creation collides with attempts to create the
> > device of
> > the same name:
> > 
> > ÂÂÂ# rmmod ifb
> > ÂÂÂ# ip link add ifb0 type ifb
> > ÂÂÂRTNETLINK answers: File exists
> > 
> > This is pretty much the same situation as was with the block loop
> > devices
> > which was solved by adding a build-time configuration that the
> > distributions could use as they deem fit while keeping the default
> > for
> > compatibility.
> > 
> > Let's do that here as well.
> 
> Thanks for the set in general, good to see it fixed!
> 
> > Signed-off-by: Lubomir Rintel <lkundrak@xxxxx>
> > ---
> [...]
> > +config IFB_COUNT
> > +ÂÂÂÂÂÂÂÂint "Number of ifb devices to pre-create at init time"
> > +ÂÂÂÂÂÂÂÂdepends on IFB
> > +ÂÂÂÂÂÂÂÂdefault 3
> 
> Should that not be 2?

Yes, it should be. Good catch, thanks. Will follow-up with a fixed
patch.

Lubo