Re: [PATCH v2 0/2] mfd: act8945a: add Active-semi ACT8945A PMIC MFD driver

From: Lee Jones
Date: Tue Jan 12 2016 - 03:45:52 EST


On Tue, 12 Jan 2016, Wenyou Yang wrote:

> This patch set adds support for the Active-semi ACT8945A PMIC
> MFD driver. It is a Multi Function Device with the following
> subdevices:
> - Regulator
> - Charger
>
> It is interfaced to the host controller using I2C interface,
> ACT8945A is a child device of the I2C.
>
> Changes in v2:
> - add more help information in Kconfig.
> - update the file header with short version license and author line.
> - remove unused structure members (dev, i2c_client) of stuct act8945a_dev.
> - use define "PLATFORM_DEVID_NONE" for mfd_add_devices(), instead of '-1'.
> - use more explicit info to indicate the failure to add sub devices.
> - remove the unnecessary print out.
> - substitute MODULE_LICENSE("GPL") for MODULE_LICENSE("GPL v2").
> - use more specific label in Example.
> - add pmic and charger nodes in Example.
>
> Wenyou Yang (2):
> mfd: act8945a: add Active-semi ACT8945A PMIC MFD driver
> mfd: add documentation for ACT8945A DT bindings

Sending out 3 patch-sets for related changes is a pretty
unconventional way of doing things. In future could you place them
all in the same place, that way all of the patches stay together whist
hopping around our inboxes.

> Documentation/devicetree/bindings/mfd/act8945a.txt | 82 +++++++++++++++
> drivers/mfd/Kconfig | 11 ++
> drivers/mfd/Makefile | 1 +
> drivers/mfd/act8945a.c | 109 ++++++++++++++++++++
> include/linux/mfd/act8945a.h | 21 ++++
> 5 files changed, 224 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/act8945a.txt
> create mode 100644 drivers/mfd/act8945a.c
> create mode 100644 include/linux/mfd/act8945a.h
>

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog