Re: [PATCH] thinkpad_acpi: Add support for keyboard backlight

From: Pali RohÃr
Date: Mon Jan 11 2016 - 15:03:09 EST


On Monday 11 January 2016 20:28:00 Henrique de Moraes Holschuh wrote
> The two features are not the same (and are handled differently by the
> firmware, for whatever reason), although they do serve the same
> purpose. I don't think a thinkpad will ever have both features at
> the same time, so I have no idea why they changed the firmware
> interface.

Maybe we should decide if ::kbd_backlight LED suffix could be used also
for other LED devices and not only for those which are physically under
the keyboard.

At least I understand "keyboard backlight" as light which is under the
keyboard...

And more important, I was told that ThinkPad x230 comes in variant with
both ThinkLight (that LED upper the display) and keyboard backlight
(under they keyboard).

So I'm against merging ThinkLight and keyboard backlight to one sysfs
path...

--
Pali RohÃr
pali.rohar@xxxxxxxxx

Attachment: signature.asc
Description: This is a digitally signed message part.