Re: [PATCH 2/2] virtio_balloon: fix race between migration and ballooning

From: Minchan Kim
Date: Sun Jan 10 2016 - 18:52:27 EST


On Sun, Jan 10, 2016 at 11:40:17PM +0200, Michael S. Tsirkin wrote:
> On Mon, Jan 04, 2016 at 09:27:47AM +0900, Minchan Kim wrote:
> > > I think this will cause deadlocks.
> > >
> > > pages_lock now nests within page lock, balloon_page_putback
> > > nests them in the reverse order.
> >
> > In balloon_page_dequeu, we used trylock so I don't think it's
> > deadlock.
>
> I went over this again and I don't see the issue anymore.
> I think I was mistaken, so I dropped my patch and picked
> up yours. Sorry about the noise.

No problem. Thanks for the review.