Re: [PATCH -next] gpio: xilinx: Do not use gpiochip_get_data() in xgpio_save_regs()

From: Linus Walleij
Date: Thu Jan 07 2016 - 04:08:04 EST


On Thu, Jan 7, 2016 at 1:20 AM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:

> Commit 097d88e94c44 ("gpio: xilinx: use gpiochip data pointer") replaces
> the use of container_of() with gpiochip_get_data(). Unfortunately, the
> data pointer is not yet set by the time xgpio_save_regs() is called,
> causing a system hang.
>
> Fixes: 097d88e94c44 ("gpio: xilinx: use gpiochip data pointer")
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
> It might make sense to merge this patch with the patch introducing the problem.

Patch applied, thanks for finding and fixing this so quick!

(I hope I haven't created too many of these regressions...)

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/