Re: [PATCH 1/2] regmap: irq: add support for configuration of trigger type

From: Mark Brown
Date: Tue Jan 05 2016 - 12:41:29 EST


On Tue, Dec 22, 2015 at 06:25:26PM +0530, Laxman Dewangan wrote:

> + d->type_reg_stride = chip->type_reg_stride ? : 1;
> +

Please don't abuse the ternery operator, especially not the GCC
extension - that's much less clear than just writing the if statement.

Attachment: signature.asc
Description: PGP signature