Re: [PATCHv7] EDAC, altera: Add Altera L2 Cache and OCRAM EDAC Support

[Dinh Nguyen]

On 01/04/2016 02:30 PM, Borislav Petkov wrote:
> On Mon, Jan 04, 2016 at 02:04:08PM -0600, Dinh Nguyen wrote:
>> altr_edac.c originally added support for SDRAM. Now we're adding support
>> for L2 and OCRAM into the same file by using #ifdef
>> CONFIG_EDAC_ALTERA_OCRAM and CONFIG_EDAC_ALTERA_L2C. So "clean" was to
>> move the l2 and ocram implementation into separate files.
> 
> So what's wrong with adding those to the same file and using different
> registration functions? Like xgene_edac does, for example.
> 

I don't see a way for the xgene to manually build for each configuration
using Kconfig? For SoCFGPA, we would like to keep the option to build
for each type of ECC.

Dinh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/