Re: [PATCH] regmap: flat: introduce register striding to savesomememories

From: Xiubo Li
Date: Wed Dec 30 2015 - 20:36:23 EST




On 31/12/2015 01:58, Mark Brown wrote:
On Fri, Dec 18, 2015 at 04:59:38PM +0800, lixiubo@xxxxxxxxxxxxxxxxxxxx wrote:

I think we'll need to continue supporting non power of two strides so
an unconditional conversion to shifts might be an issue - some weird DSP
probably does that.

Yes, agreed.

IMO this won't happen to MMIO, and for the device using MMIO the
register strides should equal to power of two.

Are there some cases I have met?

DSPs exposed via I2C and SPI are the main things I'm worried about.
It's fairly common for DSPs to have unusual word sizes including things
like three bytes.


Yes, if so, for this case the non power of two strides should be still supported.

Thanks for your promotion, and I will think over of this carefully.

BRs

Xiubo Li




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/