Re: [PATCH] arm: kernel: utilize hrtimer based broadcast

From: Arnd Bergmann
Date: Mon Dec 28 2015 - 06:55:13 EST


On Monday 28 December 2015 07:18:58 Huan Wang wrote:
> Hi, Arnd,
>
> Could you help to review the following patch? Thanks.
>

Hi Alison,

I'm sorry but I understand very little of this particular area of the kernel.

I've added Daniel Lezcano, John Stultz and Thomas Gleixner to Cc, they all
know this much better than I do and one of them should be able to comment after
their Christmas break.

Arnd

> > On Fri, Jul 17, 2015 at 10:11:52AM +0100, Alison Wang wrote:
> > > Hrtimer based broadcast is used on ARM platform. It can be registered
> > > as the tick broadcast device in the absence of a real external clock
> > > device.
> > >
> > > Signed-off-by: Alison Wang <alison.wang@xxxxxxxxxxxxx>
> >
> > This looks sensible to me. FWIW:
> >
> > Acked-by: Mark Rutland <mark.rutland@xxxxxxx>
> >
> > Thanks,
> > Mark.
> >
> > > ---
> > > arch/arm/kernel/time.c | 3 +++
> > > 1 file changed, 3 insertions(+)
> > >
> > > diff --git a/arch/arm/kernel/time.c b/arch/arm/kernel/time.c index
> > > a66e37e..a9bc73c 100644
> > > --- a/arch/arm/kernel/time.c
> > > +++ b/arch/arm/kernel/time.c
> > > @@ -12,6 +12,7 @@
> > > * reading the RTC at bootup, etc...
> > > */
> > > #include <linux/clk-provider.h>
> > > +#include <linux/clockchips.h>
> > > #include <linux/clocksource.h>
> > > #include <linux/errno.h>
> > > #include <linux/export.h>
> > > @@ -121,5 +122,7 @@ void __init time_init(void)
> > > of_clk_init(NULL);
> > > #endif
> > > clocksource_of_init();
> > > +
> > > + tick_setup_hrtimer_broadcast();
> > > }
> > > }


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/