Re: [PATCH 2/2] pinctrl: single: remove misuse of IRQF_NO_SUSPEND flag

From: Sudeep Holla
Date: Fri Dec 04 2015 - 11:11:23 EST




On 04/12/15 15:59, Grygorii Strashko wrote:

Sorry, I can't test it right now :(
Potential fix below:

I had posted similar patch a while ago which Tony rejected.
I might have made a mistake of not putting them together, though they
were part of the same series[1], patch 12 and 16

diff --git a/arch/arm/mach-omap2/pm34xx.c b/arch/arm/mach-omap2/pm34xx.c
index 2dbd378..4e56fd9 100644
--- a/arch/arm/mach-omap2/pm34xx.c
+++ b/arch/arm/mach-omap2/pm34xx.c
@@ -481,7 +481,7 @@ int __init omap3_pm_init(void)

/* IO interrupt is shared with mux code */
ret = request_irq(omap_prcm_event_to_irq("io"),
- _prcm_int_handle_io, IRQF_SHARED | IRQF_NO_SUSPEND, "pm_io",
+ _prcm_int_handle_io, IRQF_SHARED, "pm_io",
omap3_pm_init);
enable_irq(omap_prcm_event_to_irq("io"));

@@ -489,6 +489,7 @@ int __init omap3_pm_init(void)
pr_err("pm: Failed to request pm_io irq\n");
goto err2;
}
+ enable_irq_wake(omap_prcm_event_to_irq("io"));

ret = pwrdm_for_each(pwrdms_setup, NULL);
if (ret) {




[1] http://lkml.iu.edu/hypermail/linux/kernel/1509.2/03937.html
--
Regards,
Sudeep
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/