Re: [PATCH v8 02/17] drm: bridge: analogix/dp: split exynos dp driver to bridge directory

[Yakir Yang]

Hi Heiko,

Thanks you for feedback, I do see some conflicts in Exynos Make/Kconfig
file [02/17] and dtsi file [07/17] when I try to apply this series on 
4.4-rc1
branch.

Hmm... Due to I have update some patches to version 10 already, this
series may be become harder to reviewed, should I just send the whole
series out that update the version to v10.

Thanks
- Yakir


On 11/27/2015 01:30 AM, Heiko Stübner wrote:
> Hi Yakir,
>
> Am Mittwoch, 28. Oktober 2015, 16:21:59 schrieb Yakir Yang:
> > Split the dp core driver from exynos directory to bridge directory,
> > and rename the core driver to analogix_dp_*, rename the platform
> > code to exynos_dp.
> >
> > Beside the new analogix_dp driver would export four hooks.
> > "analogix_dp_bind()" and "analogix_dp_unbind()"
> > "analogix_dp_detect()" and "analogix_dp_get_modes()"
> >
> > The bind/unbind symbols is used for analogix platform driver to connect
> > with analogix_dp core driver. And the detect/get_modes is used for analogix
> > platform driver to init the connector.
> >
> > They reason why connector need register in helper driver is rockchip drm
> > haven't implement the atomic API, but Exynos drm have implement it, so
> > there would need two different connector helper functions, that's why we
> > leave the connector register in helper driver.
> >
> > Tested-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
> > Signed-off-by: Yakir Yang <ykk@xxxxxxxxxxxxxx>
> [...]
>
> > diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig
> > index bd1a415..5f74f80 100644
> > --- a/drivers/gpu/drm/exynos/Kconfig
> > +++ b/drivers/gpu/drm/exynos/Kconfig
> > @@ -55,8 +55,9 @@ config DRM_EXYNOS_DSI
> >   	  This enables support for Exynos MIPI-DSI device.
> >
> >   config DRM_EXYNOS_DP
> > -	bool "EXYNOS DRM DP driver support"
> > +	bool "EXYNOS specific extensions for Analogix DP driver"
> >   	depends on DRM_EXYNOS && (DRM_EXYNOS_FIMD || DRM_EXYNOS7_DECON)
> > +	select DRM_ANALOGIX_DP
> >   	default DRM_EXYNOS
> >   	select DRM_PANEL
> >   	help
> This doesn't apply anymore to 4.4-rc due to other changes in there. The
> exynos/Makefile is affected as well.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/