Re: [PATCH V3 net-next 2/5] net:hns: Add Hip06 "RSS(Receive Side Scaling)" support to HNS Driver

From: Salil Mehta
Date: Thu Nov 26 2015 - 02:32:36 EST



On 11/22/2015 9:30 AM, Yuval Mintz wrote:
static void hns_ppe_init_hw(struct hns_ppe_cb *ppe_cb) {
...
+ /* Set default RSS key and indrection table*/
+ const u32 rss_key[HNS_PPEV2_RSS_KEY_NUM] = {
+ 0x6d5a56da, 0x255b0ec2,
+ 0x4167253d, 0x43a38fb0,
+ 0xd0ca2bcb, 0xae7b30b4,
+ 0x77cb2da3, 0x8030f20c,
+ 0x6a42b73b, 0xbeac01fa,
+ };
+
+ /* set default RSS key and remember it */
+ for (i = 0; i < HNS_PPEV2_RSS_KEY_NUM; i++)
+ ppe_cb->rss_key[i] = rss_key[i];

Is there any reason for the special default key?
Why not use netdev_rss_key_fill()?
Thanks for pointing out this. I have incorported this change in latest PATCH V5



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/